Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPDATE prettier and remove unused dependencies #1438

Merged
merged 1 commit into from
Jul 8, 2017
Merged

UPDATE prettier and remove unused dependencies #1438

merged 1 commit into from
Jul 8, 2017

Conversation

ndelangen
Copy link
Member

Issue: -outdated prettier- -noticed a few unused dependencies-

What I did

Updated prettier
Removed unused dependencies

How to test

Everything should continue to work as normal
Running lint on js & md should validate this work.

@ndelangen ndelangen added the cleanup Minor cleanup style change that won't show up in release changelog label Jul 8, 2017
@ndelangen ndelangen self-assigned this Jul 8, 2017
shilman
shilman approved these changes Jul 8, 2017
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jul 8, 2017 •
edited
Loading

Codecov Report

Merging #1438 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1438   +/-   ##
=======================================
  Coverage   14.34%   14.34%           
=======================================
  Files         201      201           
  Lines        4614     4614           
  Branches      498      554   +56     
=======================================
  Hits          662      662           
+ Misses       3523     3486   -37     
- Partials      429      466   +37
Impacted Files Coverage Δ
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/left_panel/header.js 28.57% <0%> (ø) ⬆️
...src/server/config/WatchMissingNodeModulesPlugin.js 0% <0%> (ø) ⬆️
app/react/src/server/build.js 0% <0%> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ce512...51be2c7. Read the comment docs.

@shilman shilman merged commit d58731e into master Jul 8, 2017
@shilman shilman deleted the prettier-update-unused-dep-cleanup branch July 8, 2017 22:58
This was referenced Sep 19, 2018
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees

@ndelangen ndelangen

Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ndelangen @shilman